Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused/single use methods #14739

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Remove unused/single use methods #14739

merged 6 commits into from
Jan 22, 2024

Conversation

mroeschke
Copy link
Contributor

Description

  • Didn't see use of get_numeric_type_info
  • Column._minmax was only used once. Replaced with Column._reduce
  • CategoryColumn.unary_operator raises like the base class

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 10, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 10, 2024 22:37
@shwina
Copy link
Contributor

shwina commented Jan 22, 2024

/merge

@rapids-bot rapids-bot bot merged commit f258d04 into rapidsai:branch-24.02 Jan 22, 2024
68 checks passed
@mroeschke mroeschke deleted the cln/assorted branch January 22, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @shwina