Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up base column methods #14725

Merged
merged 11 commits into from
Jan 12, 2024
Merged

Clean up base column methods #14725

merged 11 commits into from
Jan 12, 2024

Conversation

mroeschke
Copy link
Contributor

Description

  • Removed the need for a drop_nan argument in Column.dropna
  • Removed the need for Column.as_frame
  • Removed the need for Column.force_deep_copy

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 9, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 9, 2024 02:05
isVoid
isVoid approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Removing as_frame means the class relationship between column and frame is now clear.

python/cudf/cudf/core/column/categorical.py Outdated
Comment on lines 1000 to 1004
if isinstance(cats.dtype, IntervalDtype):
# leaving out dropna because it temporarily changes an interval
# index into a struct and throws off results.
# TODO: work on interval index dropna
categories = col.categories.to_pandas()
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch can be removed.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c0a3cd1 into rapidsai:branch-24.02 Jan 12, 2024
68 checks passed
@mroeschke mroeschke deleted the ref/column/clean_methods branch January 12, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@vyasr vyasr vyasr approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @vyasr @isVoid