Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace as_numerical with as_numerical_column/codes #14719

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Replace as_numerical with as_numerical_column/codes #14719

merged 4 commits into from
Jan 10, 2024

Conversation

mroeschke
Copy link
Contributor

Description

  • For datetime/timedelta, replaced with as_numerical_column("int64")
  • For categorical, replaced with codes

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 8, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 8, 2024 18:32
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fa37e13 into rapidsai:branch-24.02 Jan 10, 2024
67 checks passed
@mroeschke mroeschke deleted the ref/as_numerical branch January 10, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @isVoid