Ensure DataFrame column types are preserved during serialization #14705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
bug
pentschev
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Thanks @mroeschke , I can confirm this resolves the issue as reported in rapidsai/ucxx#149 .
charlesbluca
approved these changes
Jan 8, 2024
|
/merge |
1 similar comment
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/ucxx
that referenced
this pull request
Jan 9, 2024
Empty cuDF dataframe serialization was fixed in rapidsai/cudf#14705 . Closes #149 . Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
xref rapidsai/ucxx#149
Ensures column subclass e.g
RangeIndexand data types e.g.int8are preserved during serialization.I think this should be backwards compatible since we're just adding keys to the the serialized
headerdict and the deserialization checks if those new keys existChecklist