Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Z in datetime string parsing in non pandas compat mode #14701

Merged
merged 7 commits into from
Jan 6, 2024
Merged

Allow Z in datetime string parsing in non pandas compat mode #14701

merged 7 commits into from
Jan 6, 2024

Conversation

mroeschke
Copy link
Contributor

Description

xref #14039 (comment)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Jan 3, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 3, 2024 20:22
@mroeschke mroeschke requested review from bdice and isVoid January 3, 2024 20:22
bdice
bdice reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments. We need to follow up with a deprecation for the behavior that doesn't align with pandas, and eventually make a breaking change for that since it's a bug that cudf and pandas disagree on the behavior. We'll need the Morpheus team (@cwharris) to update their code accordingly. (xref: #14039 (comment))

python/cudf/cudf/tests/test_datetime.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_datetime.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_datetime.py Outdated Show resolved Hide resolved
@bdice bdice mentioned this pull request Jan 3, 2024
Closed
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6083efa into rapidsai:branch-24.02 Jan 6, 2024
67 checks passed
@mroeschke mroeschke deleted the compat/dt_parsing branch January 6, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@cwharris cwharris cwharris approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @cwharris @bdice