Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use offsetalator in gather_chars #14700

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Update cudf::strings::detail::gather_chars() utility to use the offsetalator iterators.
The offsetalator enables the utility to use int32 or int64 offsets in the future with no additional changes.
This utility is mainly used by a make_strings_column factory and is already optimized for columns with both long and short strings.
The input_offsetalator is also updated to include an additional optional offset parameter for cases where the parent strings column has been sliced and requires building the iterator starting from a non-zero index within the offsets child column.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 3, 2024
@davidwendt davidwendt self-assigned this Jan 3, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 5, 2024
@davidwendt davidwendt marked this pull request as ready for review January 5, 2024 13:38
@davidwendt davidwendt requested a review from a team as a code owner January 5, 2024 13:38
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fc142eb into rapidsai:branch-24.02 Jan 8, 2024
68 checks passed
@davidwendt davidwendt deleted the gather-chars-offsetalator branch January 8, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants