Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change io::detail::orc namespace into io::orc::detail #14696

Merged
merged 8 commits into from
Jan 3, 2024
Merged

Change io::detail::orc namespace into io::orc::detail #14696

merged 8 commits into from
Jan 3, 2024

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Jan 2, 2024 •
edited
Loading

This PR simply changes the (sub) namespace io::detail::orc namespace into io::orc::detail. From now, the implementation of ORC reader and writer will be part of the detail namespace under the io::orc namespace.

ttnghia added 2 commits January 2, 2024 12:33
@ttnghia
Change namespace
3fb08f7 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Update copyright year
46cb03d 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia added 3 - Ready for Review Ready for review by team libcudf blocker libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Jan 2, 2024
@ttnghia ttnghia requested a review from vuule January 2, 2024 20:42
@ttnghia ttnghia self-assigned this Jan 2, 2024
@ttnghia ttnghia requested a review from a team as a code owner January 2, 2024 20:42
@ttnghia ttnghia requested a review from harrism January 2, 2024 20:42
@ttnghia ttnghia added the improvement Improvement / enhancement to an existing function label Jan 2, 2024
vuule
vuule reviewed Jan 2, 2024
View reviewed changes
cpp/include/cudf/io/orc.hpp Outdated Show resolved Hide resolved
@ttnghia @vuule
Update cpp/include/cudf/io/orc.hpp
e8d482c 
Co-authored-by: Vukasin Milovanovic <[email protected]>
hyperbolic2346
hyperbolic2346 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

mythrocks
mythrocks approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is much better.

vuule
vuule reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few more redundancies
looks great otherwise

cpp/src/io/orc/writer_impl.hpp Outdated Show resolved Hide resolved
cpp/src/io/functions.cpp Outdated Show resolved Hide resolved
cpp/src/io/functions.cpp Show resolved Hide resolved
@ttnghia
Copy link
Contributor Author

ttnghia commented Jan 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit a9ca11f into rapidsai:branch-24.02 Jan 3, 2024
67 checks passed
@ttnghia ttnghia deleted the refactor_orc_namespace branch January 3, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule left review comments

@mythrocks mythrocks mythrocks approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ttnghia @hyperbolic2346 @mythrocks @vuule