Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nan_as_null not being respected when passing arrow object #14688

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix nan_as_null not being respected when passing arrow object #14688

merged 1 commit into from
Jan 11, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Similar to #14687, nan was not being interpreted as null when nan_as_null=True

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Dec 29, 2023
@mroeschke mroeschke requested a review from a team as a code owner December 29, 2023 20:48
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d26ea6d into rapidsai:branch-24.02 Jan 11, 2024
68 checks passed
@mroeschke mroeschke deleted the bug/constr/nan_as_null_arrow_objs branch January 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr