-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add row conversion code from spark-rapids-jni #14664
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
46d0a68
Change row_conversion code in Java folder
ttnghia 77bae6b
Add row conversion code and tests into libcudf
ttnghia 0f4a467
Revert the previously workaround code
ttnghia be601ce
Fix spell, style, and copyright year
ttnghia 965f8bf
Merge branch 'branch-24.02' into row_conversion
ttnghia eff16a5
Suppress doxygen
ttnghia e286421
Remove unused Java code
ttnghia 6d2d293
Merge remote-tracking branch 'nghia/row_conversion' into row_conversion
ttnghia 7f47b50
Change CMake file
ttnghia c051e9d
Merge remote-tracking branch 'origin/pull-request/14664' into row_con…
ttnghia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Copyright (c) 2022-2023, NVIDIA CORPORATION. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#pragma once | ||
|
||
#include <memory> | ||
|
||
#include <cudf/lists/lists_column_view.hpp> | ||
#include <cudf/table/table_view.hpp> | ||
#include <cudf/utilities/default_stream.hpp> | ||
#include <rmm/cuda_stream_view.hpp> | ||
|
||
namespace cudf { | ||
|
||
std::vector<std::unique_ptr<cudf::column>> convert_to_rows_fixed_width_optimized( | ||
cudf::table_view const& tbl, | ||
// TODO need something for validity | ||
rmm::cuda_stream_view stream = cudf::get_default_stream(), | ||
rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource()); | ||
|
||
std::vector<std::unique_ptr<cudf::column>> convert_to_rows( | ||
cudf::table_view const& tbl, | ||
// TODO need something for validity | ||
rmm::cuda_stream_view stream = cudf::get_default_stream(), | ||
rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource()); | ||
|
||
std::unique_ptr<cudf::table> convert_from_rows_fixed_width_optimized( | ||
cudf::lists_column_view const& input, | ||
std::vector<cudf::data_type> const& schema, | ||
rmm::cuda_stream_view stream = cudf::get_default_stream(), | ||
rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource()); | ||
|
||
std::unique_ptr<cudf::table> convert_from_rows( | ||
cudf::lists_column_view const& input, | ||
std::vector<cudf::data_type> const& schema, | ||
rmm::cuda_stream_view stream = cudf::get_default_stream(), | ||
rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource()); | ||
|
||
} // namespace cudf |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is just copied/moved from java/src/main/native/src/row_conversion.hpp