-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split parquet test into multiple files #14663
Split parquet test into multiple files #14663
Conversation
Latest changes get the compile time down to 19s. |
/ok to test |
A bit of scope creep...while trying to figure out where compile time was going, I found that including |
/ok to test |
I'll measure the build time locally (tomorrow) to help confirm that this change does reduce the total build time. |
/ok to test |
The new quote_normalization_test file needs to be updated, got an error building locally. |
/ok to test |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
90 files. 8K lines. All solid :D
/merge |
Description
Compiling the parquet C++ tests takes a long time. This work attempts to address this by splitting the (mostly) monolithic
parquet_test.cpp
into multiple compilation units. On my workstation (10 core i7) I was able to reduce the compile time for PARQUET_TEST from 48s down to 23s.This PR also splits the testing
base_fixture.hpp
file into three parts to cut down on unnecessary rmm includes. This change resulted in a time savings of around 20% when compiling the entire test suite locally.Checklist