Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING for pyproject-only builds #14653

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 19, 2023

Description

Now that we no longer have setup.py, builds must be handled by a front-end like pip install.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added doc Documentation non-breaking Non-breaking change labels Dec 19, 2023
@vyasr vyasr self-assigned this Dec 19, 2023
@DanialJavady96
Copy link
Contributor

DanialJavady96 commented Dec 19, 2023

Wanted to comment from an outsiders POV, the wording in the docs say

First, build the libcudf C++ library following the steps above but you will need to build cudf & libcudf, not just libcudf right? Maybe "build the libcudf C++ library and cudf library" would be helpful or just including ./build.sh libcudf cudf in the instructions there

@vyasr
Copy link
Contributor Author

vyasr commented Dec 19, 2023

That's a good point, there's really no reason not to prefer build.sh here. I'll update again.

Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (also great to have an option to install in editable mode too!)

@vyasr
Copy link
Contributor Author

vyasr commented Dec 20, 2023

/merge

@rapids-bot rapids-bot bot merged commit 96a1b00 into rapidsai:branch-24.02 Dec 20, 2023
67 checks passed
@vyasr vyasr deleted the fix/contributing_setup branch December 20, 2023 02:03
@mroeschke
Copy link
Contributor

Noting that when I build with --pydevelop, I get this error when importing cudf

In [1]: import cudf
---------------------------------------------------------------------------
FileNotFoundError                         Traceback (most recent call last)
Cell In[1], line 1
----> 1 import cudf

File ~/python/cudf/cudf/__init__.py:9
      6 from cudf.utils._numba import _setup_numba
      7 from cudf.utils.gpu_utils import validate_setup
----> 9 _setup_numba()
     10 validate_setup()
     12 import cupy

File ~/python/cudf/cudf/utils/_numba.py:122, in _setup_numba()
    120 if versions != NO_DRIVER:
    121     driver_version, runtime_version = versions
--> 122     ptx_toolkit_version = _get_cuda_version_from_ptx_file(CC_60_PTX_FILE)
    124     # MVC is required whenever any PTX is newer than the driver
    125     # This could be the shipped PTX file or the PTX emitted by
    126     # the version of NVVM on the user system, the latter aligning
    127     # with the runtime version
    128     if (driver_version < ptx_toolkit_version) or (
    129         driver_version < runtime_version
    130     ):

File ~/python/cudf/cudf/utils/_numba.py:157, in _get_cuda_version_from_ptx_file(path)
    137 def _get_cuda_version_from_ptx_file(path):
    138     """
    139     https://docs.nvidia.com/cuda/parallel-thread-execution/
    140     Each PTX module must begin with a .version
   (...)
    155 
    156     """
--> 157     with open(path) as ptx_file:
    158         for line in ptx_file:
    159             if line.startswith(".version"):

FileNotFoundError: [Errno 2] No such file or directory: '.../python/cudf/cudf/utils/../core/udf/shim_60.ptx'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants