Constrain CUDA in notebook testing to prevent CUDA 12.1 usage until we have pynvjitlink #14648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we have pynvjitlink
vyasr
changed the title
raydouglass
approved these changes
Dec 18, 2023
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
Follow up to #14648 Since `rapidsai/docker` tests the notebooks on both CUDA 11.8 & 12.0, we need a CUDA 11.8 version of the `test_notebooks` file key. Without this change rdfg wlll always generate an environment with `cuda-version=12.0` even when the matrix is for CUDA 11.8 and then it will conflict with other repos (as see [here](https://github.com/rapidsai/docker/actions/runs/7451820911/job/20273765522#step:10:316)). Authors: - Ray Douglass (https://github.com/raydouglass) - Bradley Dice (https://github.com/bdice) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Bradley Dice (https://github.com/bdice) URL: #14722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our notebook tests will currently fail to run because CUDA 12.1 is now available on conda-forge. We need to constrain the testing environment (we already do this for non-notebook testing environments).
Checklist