Basic validation in reader benchmarks #14647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bm-basic-validation
…bm-basic-validation
…bm-basic-validation
vuule
added
tests
vuule
commented
Dec 20, 2023
Comment on lines
+65
to
+67
| size_t const chunk_size = cudf::util::div_rounding_up_safe(source_sink.size(), num_chunks); | ||
| auto const chunk_row_cnt = | ||
| cudf::util::div_rounding_up_safe(view.num_rows(), static_cast<cudf::size_type>(num_chunks)); |
There was a problem hiding this comment.
The old approach was rounding down and losing some rows. Adding the check uncovered the issue.
Also some logic in the loop got simplified by rounding up here.
PointKernel
approved these changes
Dec 20, 2023
Co-authored-by: Yunsong Wang <[email protected]>
…nto bm-basic-validation
hyperbolic2346
approved these changes
Dec 27, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check the output table shape in the CSV, JSON, ORC and Parquet reader benchmarks.
Other changes:
Fixed some chunking logic in the CSV reader benchmark.
Shortened the lifetime of the original table to reduce peak memory use (adopted the pattern from the JSON reader benchmark).
Checklist