Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate memoryview handling in as_column #14643

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Consolidate memoryview handling in as_column #14643

merged 1 commit into from
Dec 18, 2023

Conversation

mroeschke
Copy link
Contributor

Description

Implemented @wence- 's suggestion in #14636 (comment)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 16, 2023
@mroeschke mroeschke requested a review from a team as a code owner December 16, 2023 00:41
mroeschke
mroeschke commented Dec 16, 2023
View reviewed changes
python/cudf/cudf/core/column/column.py
)
elif isinstance(arbitrary, cudf.Scalar):
data = ColumnBase.from_scalar(arbitrary, length if length else 1)
else:
if dtype is not None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block is just unindented from a removed try/except

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 90cccef into rapidsai:branch-24.02 Dec 18, 2023
67 checks passed
@mroeschke mroeschke deleted the ref/as_column/memoryview branch December 18, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @bdice