Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert FieldType to scoped enum #14642

Merged
merged 17 commits into from
Jan 9, 2024
Merged

Convert FieldType to scoped enum #14642

merged 17 commits into from
Jan 9, 2024

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Dec 15, 2023

Description

Switch to scoped enum (enum class); they are better because, well, values now have a scope.
Another benefit in this case - values are now named consistently with compact protocol.
De-duplicated some code, now that more static_casts are required and duplication stands out more.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added cuIO cuIO issue tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 15, 2023
@vuule vuule self-assigned this Dec 15, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 15, 2023
@vuule vuule changed the title Convert FieldType to scoped enum Convert FieldType to scoped enum Dec 15, 2023
@vuule vuule marked this pull request as ready for review December 19, 2023 18:17
@vuule vuule requested a review from a team as a code owner December 19, 2023 18:17
@vuule vuule requested review from vyasr and nvdbaranec December 19, 2023 18:17
mythrocks
mythrocks approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vuule
Copy link
Contributor Author

vuule commented Jan 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit 433bdc3 into rapidsai:branch-24.02 Jan 9, 2024
67 checks passed
@vuule vuule deleted the impr-enum-class-fieldtype branch January 9, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etseidl etseidl etseidl left review comments

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks mythrocks approved these changes

@vyasr vyasr vyasr approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vuule @vyasr @mythrocks @ttnghia @etseidl