Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining copying APIs in pylibcudf along with required helper functions #14640

Merged
merged 9 commits into from
Dec 15, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 15, 2023

Description

This PR implements the remaining parts of libcudf's copying APIs in pylibcudf, updating cuDF Python to use those as a backend. The cudf copying Cython module is now largely just a set of pylibcudf calls. This represents the general transition that we hope to make, and eventually once all of cudf looks like this we can refactor its internal data structures to be built directly around pylibcudf objects we can remove these thin translation layers.

This PR also implements a few core utility functions required for translating between pylibcudf and libcudf objects, namely for:

  • Generating pylibcudf Columns from libcudf column_views (instead of owning columns)
  • Creating libcudf mutable_column_view objects from pylibcudf.Columns
  • Producing cudf DeviceScalar objects from pylibcudf Scalars.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr self-assigned this Dec 15, 2023
@vyasr vyasr added feature request New feature or request non-breaking Non-breaking change labels Dec 15, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 15, 2023
@vyasr vyasr added 3 - Ready for Review Ready for review by team Cython labels Dec 15, 2023
@vyasr vyasr marked this pull request as ready for review December 15, 2023 19:48
@vyasr vyasr requested a review from a team as a code owner December 15, 2023 19:48
@vyasr vyasr requested review from wence- and mroeschke December 15, 2023 19:48
@vyasr
Copy link
Contributor Author

vyasr commented Dec 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 9c16d89 into rapidsai:branch-24.02 Dec 15, 2023
67 checks passed
@vyasr vyasr deleted the feat/pylibcudf_copying_extra branch December 15, 2023 22:41
@vyasr vyasr added the pylibcudf Issues specific to the pylibcudf package label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants