Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Pascal GPU support. #14630

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 14, 2023

Description

Closes #14629.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner December 14, 2023 15:18
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 14, 2023
@bdice
Copy link
Contributor Author

bdice commented Dec 14, 2023

@vuule There are a couple places where the C++ code has special handling for disabling ZSTD compression on Pascal. Can you weigh in on whether that is safe to remove, since 24.02 will not support Pascal GPUs?

// 2.4.0 disabled on Pascal

if (NVCOMP_ZSTD_IS_DISABLED_ON_PASCAL(

@vuule
Copy link
Contributor

vuule commented Dec 14, 2023

@vuule There are a couple places where the C++ code has special handling for disabling ZSTD compression on Pascal. Can you weigh in on whether that is safe to remove, since 24.02 will not support Pascal GPUs?

// 2.4.0 disabled on Pascal

if (NVCOMP_ZSTD_IS_DISABLED_ON_PASCAL(

Should be safe to remove. I'd keep compute_capability_major in feature_status_parameters even though it won't be used, in case we need another workaround at a later point. We can remove the code you linked above.

@bdice bdice requested a review from a team as a code owner December 14, 2023 19:43
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 14, 2023
@bdice bdice added improvement Improvement / enhancement to an existing function breaking Breaking change labels Dec 14, 2023
@bdice bdice self-assigned this Dec 14, 2023
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md of
python/cudf/
python/cudf_kafka/
python/custreamz/
python/dask_cudf/
needs update as well.

@bdice
Copy link
Contributor Author

bdice commented Jan 2, 2024

README.md of python/cudf/ python/cudf_kafka/ python/custreamz/ python/dask_cudf/ needs update as well.

@karthikeyann Can you check this? I already updated custreamz in this PR. The cudf, cudf_kafka, and dask_cudf READMEs are all just symlinks to the root README.md so they don't need additional changes.

@bdice bdice requested a review from karthikeyann January 2, 2024 19:54
@bdice
Copy link
Contributor Author

bdice commented Jan 2, 2024

@karthikeyann I'm going to go ahead and merge this since we've had enough reviews and I think your comment is already addressed. If you see additional changes that are needed, please let me know and I'll follow up. 👍

@bdice
Copy link
Contributor Author

bdice commented Jan 2, 2024

/merge

@bdice bdice dismissed karthikeyann’s stale review January 2, 2024 21:47

Request addressed.

@rapids-bot rapids-bot bot merged commit 2be060e into rapidsai:branch-24.02 Jan 2, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Pascal.
6 participants