Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix astype/fillna not maintaining column subclass and types #14615

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix astype/fillna not maintaining column subclass and types #14615

merged 1 commit into from
Dec 12, 2023

Conversation

mroeschke
Copy link
Contributor

Description

Broken off from #14614, ensures fillna and astype can return a RangeIndex columns or maintain the original type of the columns

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Dec 12, 2023
@mroeschke mroeschke requested a review from a team as a code owner December 12, 2023 17:15
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d1ba966 into rapidsai:branch-24.02 Dec 12, 2023
67 checks passed
@mroeschke mroeschke deleted the bug/astype_fillna/columns branch December 12, 2023 19:17
@pentschev pentschev mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar