Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create strings-specific make_offsets_child_column for multiple offset types #14612

Merged
merged 24 commits into from
Jan 19, 2024
Merged

Create strings-specific make_offsets_child_column for multiple offset types #14612

merged 24 commits into from
Jan 19, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Dec 11, 2023 •
edited
Loading

Description

Creates cudf::strings::detail::make_offsets_child_column for specific use with strings offsets to enable int64 offsets.
This also introduces the LIBCUDF_LARGE_STRINGS_THRESHOLD environment variable which can be used at runtime to produce int64 offsets for an arbitrary number of character bytes. This utility is not used in this PR but will be employed in a future PR.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 11, 2023
@davidwendt davidwendt self-assigned this Dec 11, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 10, 2024
@davidwendt davidwendt marked this pull request as ready for review January 10, 2024 15:34
@davidwendt davidwendt requested a review from a team as a code owner January 10, 2024 15:34
mythrocks
mythrocks approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor nitpick.

cpp/include/cudf/strings/detail/strings_children.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/strings/detail/strings_children.cuh Outdated Show resolved Hide resolved
karthikeyann
karthikeyann approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀 This will help a lot during testing long strings developments.

@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3f7983e into rapidsai:branch-24.02 Jan 19, 2024
71 of 72 checks passed
@davidwendt davidwendt deleted the chars-size-threshold branch January 19, 2024 20:43
@GregoryKimball GregoryKimball mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@mythrocks mythrocks mythrocks approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwendt @vyasr @mythrocks @karthikeyann @ttnghia