Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the offsetalator in cudf::concatenate for strings #14611

Merged
merged 12 commits into from
Jan 8, 2024
Merged

Use the offsetalator in cudf::concatenate for strings #14611

merged 12 commits into from
Jan 8, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates the cudf::concatenate logic specialization for strings to use the offsetalator to manage the input and output offsets.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 11, 2023
@davidwendt davidwendt self-assigned this Dec 11, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Dec 15, 2023
@davidwendt davidwendt marked this pull request as ready for review December 15, 2023 14:16
@davidwendt davidwendt requested a review from a team as a code owner December 15, 2023 14:16
bdice
bdice approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are tests needed yet, or will that be covered at some later time when we allow 64-bit offsets?

@davidwendt
Copy link
Contributor Author

Are tests needed yet, or will that be covered at some later time when we allow 64-bit offsets?

All the current tests should cover this. Adding actual 64-bit offsets support will come later.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c0aa8bb into rapidsai:branch-24.02 Jan 8, 2024
67 checks passed
@davidwendt davidwendt deleted the concat-strs-offsets branch January 8, 2024 18:47
@GregoryKimball GregoryKimball mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @ttnghia