Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-empty nulls in cudf::get_json_object #14609

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Remove non-empty nulls in cudf::get_json_object #14609

merged 1 commit into from
Dec 12, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Dec 11, 2023 •
edited
Loading

Description

Removes unsanitized rows from output result of cudf::get_json_object which may occur when querying an array path $[*] does not find any matches in the target string. In this case, a single '[' remains in the output buffer (per row) though the row is marked as a null entry.
This fixes the JsonPathTests.GetJsonObjectInvalidQuery error found in #14559

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Dec 11, 2023
@davidwendt davidwendt self-assigned this Dec 11, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Dec 12, 2023
@davidwendt davidwendt marked this pull request as ready for review December 12, 2023 00:18
@davidwendt davidwendt requested a review from a team as a code owner December 12, 2023 00:18
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 21c90d6 into rapidsai:branch-24.02 Dec 12, 2023
67 checks passed
@davidwendt davidwendt deleted the fix-unsanitized-json-path branch December 12, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr vyasr approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @vyasr @ttnghia