Remove WORKSPACE env var from cudf_test temp_directory class #14588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
ttnghia
approved these changes
Dec 6, 2023
bdice
approved these changes
Dec 7, 2023
|
I actually used this when I wanted to save the generated files in IO benchmarks. |
|
from https://en.cppreference.com/w/cpp/filesystem/temp_directory_path:
So that should work fine as well. I'll give it a try. |
|
|
vuule
approved these changes
Dec 7, 2023
|
/merge |
karthikeyann
pushed a commit
to karthikeyann/cudf
that referenced
this pull request
Dec 12, 2023
…i#14588) Removes the `WORKSPACE` env var check from the `cudf_test` `temp_directory` class. This env var is not being used. This is part of a larger effort to consolidate and document libcudf env vars. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) - Vukasin Milovanovic (https://github.com/vuule) URL: rapidsai#14588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
WORKSPACEenv var check from thecudf_testtemp_directoryclass. This env var is not being used. This is part of a larger effort to consolidate and document libcudf env vars.Checklist