Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct invalid or missing return types #14587

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Correct invalid or missing return types #14587

merged 1 commit into from
Dec 8, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Found some invalid return statements when compiling cudf with a newer gcc.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Dec 6, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner December 6, 2023 19:00
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 6, 2023
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bb629ab into rapidsai:branch-24.02 Dec 8, 2023
67 checks passed
@robertmaynard robertmaynard deleted the bug/correct_compilation_warnings branch December 8, 2023 14:09
karthikeyann pushed a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@robertmaynard @karthikeyann
Correct invalid or missing return types (rapidsai#14587)
5f59060 
Found some invalid return statements when compiling cudf with a newer gcc.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Shruti Shivakumar (https://github.com/shrshi)

URL: rapidsai#14587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@shrshi shrshi shrshi approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @shrshi @davidwendt