Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exceptions instead of return values to handle errors in CompactProtocolReader #14582

Merged
merged 20 commits into from
Dec 14, 2023
Merged

Use exceptions instead of return values to handle errors in CompactProtocolReader #14582

Changes from 3 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
184fe98
read()s
vuule Dec 5, 2023
400825d
skip and builder
vuule Dec 5, 2023
22ad429
Merge branch 'branch-24.02' of https://github.com/rapidsai/cudf into …
vuule Dec 5, 2023
122c423
field functors
vuule Dec 6, 2023
572534a
style
vuule Dec 6, 2023
ffa3189
fail early
vuule Dec 6, 2023
c59b7ef
Merge branch 'branch-24.02' of https://github.com/rapidsai/cudf into …
vuule Dec 6, 2023
bc50e6c
finish merge
vuule Dec 6, 2023
0e58899
Merge branch 'branch-24.02' into impr-no-bool-return-error
vuule Dec 9, 2023
556318b
Merge branch 'branch-24.02' of https://github.com/rapidsai/cudf into …
vuule Dec 12, 2023
fa72400
print actual type in parquet_field_int
vuule Dec 13, 2023
8a08a24
Merge branch 'impr-no-bool-return-error' of https://github.com/vuule/…
vuule Dec 13, 2023
dfbc03d
unbreak my heart
vuule Dec 13, 2023
1ab6938
Merge branch 'branch-24.02' into impr-no-bool-return-error
vuule Dec 13, 2023
d51530b
centralize field type checking
vuule Dec 13, 2023
a105f9a
undo another debug version
vuule Dec 13, 2023
485af3d
param to template param
vuule Dec 13, 2023
87d0c61
Merge branch 'branch-24.02' of https://github.com/rapidsai/cudf into …
vuule Dec 13, 2023
816b0f6
Merge branch 'impr-no-bool-return-error' of https://github.com/vuule/…
vuule Dec 13, 2023
ec2ef64
more debug mess reverted
vuule Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion cpp/src/io/parquet/compact_protocol_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,24 @@ class parquet_field_int : public parquet_field {

T& val;

std::string type_string()
vuule marked this conversation as resolved.
Show resolved Hide resolved
{
if constexpr (EXPECTED_TYPE == ST_FLD_BYTE) {
return "byte";
} else if constexpr (EXPECTED_TYPE == ST_FLD_I32) {
return "int32";
} else if constexpr (EXPECTED_TYPE == ST_FLD_I64) {
return "int64";
}
return "unknown(EXPECTED_TYPE=" + std::to_string(EXPECTED_TYPE) + ")";
vuule marked this conversation as resolved.
Show resolved Hide resolved
}

public:
parquet_field_int(int f, T& v) : parquet_field(f), val(v) {}

inline void operator()(CompactProtocolReader* cpr, int field_type)
{
CUDF_EXPECTS(field_type == EXPECTED_TYPE, "unexpected int field type");
CUDF_EXPECTS(field_type != EXPECTED_TYPE, "expected " + type_string() + " field");
if constexpr (is_byte) {
val = cpr->getb();
} else {
Expand Down
Loading