Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bpe_merge_pairs_impl member private #14543

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Make bpe_merge_pairs_impl member private #14543

merged 2 commits into from
Dec 12, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Changes the impl member of the public bpe_merge_pairs struct to private.
Also fixes the nvtext::byte_pair_encoding doxygen to remove outdated details.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 1, 2023
@davidwendt davidwendt self-assigned this Dec 1, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Dec 4, 2023
@davidwendt davidwendt marked this pull request as ready for review December 4, 2023 19:14
@davidwendt davidwendt requested a review from a team as a code owner December 4, 2023 19:14
vyasr
vyasr approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David!

@vyasr
Copy link
Contributor

vyasr commented Dec 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit 2318548 into rapidsai:branch-24.02 Dec 12, 2023
67 checks passed
karthikeyann pushed a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@davidwendt @karthikeyann
Make bpe_merge_pairs_impl member private (rapidsai#14543)
ebb2d6a 
Changes the `impl` member of the public `bpe_merge_pairs` struct to private.
Also fixes the `nvtext::byte_pair_encoding` doxygen to remove outdated details.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Karthikeyan (https://github.com/karthikeyann)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#14543
@davidwendt davidwendt deleted the bpe-impl-private branch February 5, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @vyasr @karthikeyann