Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small clean up in io::statistics #14542

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Small clean up in io::statistics #14542

merged 1 commit into from
Dec 4, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Dec 1, 2023

Description

Removed the use of volatile, not required now that it's not used in ORC or Parquet.
Small template simplification.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added cuIO cuIO issue tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 1, 2023
@vuule vuule self-assigned this Dec 1, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 1, 2023
@vuule vuule marked this pull request as ready for review December 1, 2023 22:20
@vuule vuule requested a review from a team as a code owner December 1, 2023 22:20
@vuule vuule requested review from mythrocks and ttnghia December 1, 2023 22:20
mythrocks
mythrocks approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vuule
Copy link
Contributor Author

vuule commented Dec 4, 2023

/merge

@rapids-bot rapids-bot bot merged commit abd2a91 into rapidsai:branch-24.02 Dec 4, 2023
67 checks passed
@vuule vuule deleted the impr-stats-no-volatile branch December 4, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks mythrocks approved these changes

Assignees

@vuule vuule

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @mythrocks @ttnghia