Remove extra total chars size calculation from cudf::concatenate #14540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
davidwendt
changed the title
davidwendt
added
3 - Ready for Review
vuule
reviewed
Dec 4, 2023
vuule
approved these changes
Dec 6, 2023
karthikeyann
approved these changes
Dec 6, 2023
vuule
added
5 - Ready to Merge
ttnghia
approved these changes
Dec 6, 2023
|
/merge |
karthikeyann
pushed a commit
to karthikeyann/cudf
that referenced
this pull request
Dec 12, 2023
…idsai#14540) Changes bounds check logic in `cudf::concatenate` to remove the upfront chars bytes calculation on strings columns. The calculation was thrown away and redone later (and more efficiently) during the call to `cudf::strings::detail::concatenate`. There does not seem to be a need to check this twice. A gtest was added to make sure the appropriate exception is thrown as expected. Reference rapidsai#14202 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Karthikeyan (https://github.com/karthikeyann) - Nghia Truong (https://github.com/ttnghia) URL: rapidsai#14540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes bounds check logic in
cudf::concatenateto remove the upfront chars bytes calculation on strings columns.The calculation was thrown away and redone later (and more efficiently) during the call to
cudf::strings::detail::concatenate. There does not seem to be a need to check this twice. A gtest was added to make sure the appropriate exception is thrown as expected.Reference #14202
Checklist