Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IndexedFrame.hash_values to use cudf::hashing functions, add xxhash64 to cudf Python. #14538

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 30, 2023

Description

This PR refactors the Python code for IndexedFrame.hash_values to use the newer named C++ functions from cudf::hashing::*. I also added bindings for xxhash64 and updated some tests.

Needed for #14391.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner November 30, 2023 20:29
@bdice bdice requested review from wence- and shwina November 30, 2023 20:29
@bdice bdice marked this pull request as draft November 30, 2023 20:29
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 30, 2023
@bdice
Copy link
Contributor Author

bdice commented Nov 30, 2023

Task list:

  • Refactor Cython layer to align more closely with the C++ code (expose separate named functions, and dispatch at the Python layer) Punting on this until pylibcudf
  • Add some regression tests for xxhash64. (There isn't a Python implementation of xxhash64 unless we want to add a new testing dependency -- I'd rather have regression tests than add a reference implementation.)

@bdice bdice self-assigned this Nov 30, 2023
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 30, 2023
@bdice bdice marked this pull request as ready for review December 8, 2023 19:20
@bdice
Copy link
Contributor Author

bdice commented Dec 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit 3f4ca49 into rapidsai:branch-24.02 Dec 12, 2023
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants