Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for issue 12773 #14529

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Add a test for issue 12773 #14529

merged 5 commits into from
Dec 8, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 29, 2023

Description

Closes #12773.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. dask Dask issue non-breaking Non-breaking change labels Nov 29, 2023
@vyasr vyasr requested a review from a team as a code owner November 29, 2023 22:37
@vyasr vyasr self-assigned this Nov 29, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Nov 29, 2023

CC @wence-

@vyasr vyasr added the improvement Improvement / enhancement to an existing function label Nov 29, 2023
wence-
wence- requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would prefer to check the output value as well.

python/dask_cudf/dask_cudf/tests/test_join.py Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from wence- December 7, 2023 02:25
wence-
wence- approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wence-
Copy link
Contributor

wence- commented Dec 7, 2023

/merge

@raydouglass raydouglass merged commit 248aa2c into rapidsai:branch-24.02 Dec 8, 2023
65 of 67 checks passed
@vyasr vyasr deleted the test/issue_12773 branch December 8, 2023 01:14
karthikeyann pushed a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@vyasr @karthikeyann
Add a test for issue 12773 (rapidsai#14529)
881baeb 
Closes rapidsai#12773.

Authors:
   - Vyas Ramasubramani (https://github.com/vyasr)
   - Lawrence Mitchell (https://github.com/wence-)

Approvers:
   - GALI PREM SAGAR (https://github.com/galipremsagar)
   - Lawrence Mitchell (https://github.com/wence-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- wence- approved these changes

Assignees

@vyasr vyasr

Labels
dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API. tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] can't merge dask-cudf dataframes when index is non-numeric?
4 participants
@vyasr @wence- @galipremsagar @raydouglass