Implement more copying APIs in pylibcudf #14508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
feature request
vuule
reviewed
Nov 27, 2023
shwina
reviewed
Nov 28, 2023
|
Whoops sorry @vuule I clicked on the wrong button and re-requested you unintentionally! |
wence-
approved these changes
Dec 13, 2023
vyasr
force-pushed
the
feat/pylibcudf_all_copying
branch
from
ce381e1 to
5dd0812
Compare
|
Approved offline with the current set of changes, going to merge now. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a handful of libcudf copying APIs in pylibcudf and rewrites cudf Cython internals to use those functions where appropriate. This PR only implements those methods that can be done without any additional changes to the pylibcudf Column class. I'll follow up with other PRs for changes that require those changes.
Checklist