Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable doxygen XML generation and fix issues #14477

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Enable doxygen XML generation and fix issues #14477

merged 2 commits into from
Dec 5, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 22, 2023 •
edited
Loading

Description

Doxygen-generated XML is parsed by Breathe, so this is a prerequisite for #13846.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Nov 22, 2023
@vyasr vyasr self-assigned this Nov 22, 2023
@vyasr vyasr requested a review from a team as a code owner November 22, 2023 17:54
@vyasr vyasr requested review from karthikeyann and shrshi November 22, 2023 17:54
@vyasr vyasr requested a review from karthikeyann December 1, 2023 19:30
karthikeyann
karthikeyann approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vyasr
Copy link
Contributor Author

vyasr commented Dec 5, 2023

/merge

@rapids-bot rapids-bot bot merged commit 4054f3e into rapidsai:branch-24.02 Dec 5, 2023
67 checks passed
@vyasr vyasr deleted the feat/doxygen_xml branch December 5, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @karthikeyann