Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsanitized null from input strings column in rank_tests.cpp #14475

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Removes a non-empty null entry from a test strings column utility in rank_tests.cpp.
Behavior with unsanitized nulls in at best UB and should not be included in unit tests.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 22, 2023
@davidwendt davidwendt self-assigned this Nov 22, 2023
@davidwendt davidwendt requested a review from a team as a code owner November 22, 2023 16:51
@davidwendt davidwendt requested review from vyasr and bdice November 22, 2023 16:51
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ee3fb39 into rapidsai:branch-24.02 Nov 22, 2023
67 checks passed
@davidwendt davidwendt deleted the unsanitized-null branch November 22, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants