Enable pd.Timestamp objects to be picklable when cudf.pandas is active
#14474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…14388) Closes rapidsai#14384. `x.startswith(y)` is not a good enough check for if `x` is a subdirectory of `y`. It causes `pandasai` to be reported as a sub-package of `pandas`. Authors: - Ashwin Srinath (https://github.com/shwina) Approvers: - https://github.com/brandon-b-miller URL: rapidsai#14388
bdice
reviewed
Nov 22, 2023
| return _unpickle_timestamp, (pickled_args,) | ||
|
|
||
|
|
||
| def _unpickle_timedelta(pickled_args): |
There was a problem hiding this comment.
How is _unpickle_timedelta different from _unpickle_timestamp? Similarly for _reduce_*. They look identical to me. Do we need this duplication or can we simplify things?
There was a problem hiding this comment.
Agreed, this looks like it can be deduplicated.
There was a problem hiding this comment.
Right you are -- they are the same function and I've deduplicated
bdice
reviewed
Nov 22, 2023
vyasr
approved these changes
Nov 23, 2023
| return _unpickle_timestamp, (pickled_args,) | ||
|
|
||
|
|
||
| def _unpickle_timedelta(pickled_args): |
There was a problem hiding this comment.
Agreed, this looks like it can be deduplicated.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14471.
This PR makes
Timestampobjects picklable by registering a custom reducer forpd.Timestampobjects whencudf.pandasis active.