Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated nvtext::load_merge_pairs_file #14460

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Remove deprecated nvtext::load_merge_pairs_file #14460

merged 1 commit into from
Nov 29, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Remove deprecated nvtext::load_merge_pairs_file since it is not needed -- in favor nvtext::load_merge_pairs which accepts a strings column. Callers can use cuIO functions to load the file into a column.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 21, 2023
@davidwendt davidwendt self-assigned this Nov 21, 2023
@davidwendt davidwendt requested a review from a team as a code owner November 21, 2023 18:31
karthikeyann
karthikeyann approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Question: Is deprecated function removal considered non-breaking?

@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels Nov 28, 2023
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4558344 into rapidsai:branch-24.02 Nov 29, 2023
67 checks passed
@davidwendt davidwendt deleted the remove-dep-nvtext-bpe branch November 29, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @karthikeyann @PointKernel