Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stream parameter in public nvtext APIs #14456

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Expose stream parameter in public nvtext APIs #14456

merged 2 commits into from
Nov 22, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Add stream parameter to public APIs:

  • nvtext::is_letter()
  • nvtext::porter_stemmer_measure
  • nvtext::edit_distance()
  • nvtext::edit_distance_matrix()

Also cleaned up some of the doxygen comments and added stream gtests.

Reference #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 20, 2023
@davidwendt davidwendt self-assigned this Nov 20, 2023
@davidwendt davidwendt requested a review from a team as a code owner November 20, 2023 19:17
@github-actions github-actions bot added the CMake CMake build issue label Nov 20, 2023
vyasr
vyasr approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit cfa2d51 into rapidsai:branch-24.02 Nov 22, 2023
68 checks passed
@davidwendt davidwendt deleted the stream-nvtext-edit branch November 22, 2023 15:21
@davidwendt davidwendt mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@harrism harrism harrism approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @harrism @vyasr