Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON writer: avoid default stream use in string_scalar constructors #14444

Merged
merged 1 commit into from
Nov 17, 2023
Merged

JSON writer: avoid default stream use in string_scalar constructors #14444

merged 1 commit into from
Nov 17, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Nov 17, 2023 •
edited
Loading

Description

Added the true/false string scalars to column_to_strings_fn so they are created once, instead of creating new scalars for each boolean column (using default stream).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change labels Nov 17, 2023
@vuule vuule self-assigned this Nov 17, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 17, 2023
@vuule vuule marked this pull request as ready for review November 17, 2023 21:40
@vuule vuule requested a review from a team as a code owner November 17, 2023 21:40
@vuule vuule requested review from shrshi and ttnghia November 17, 2023 21:40
@vuule
Copy link
Contributor Author

vuule commented Nov 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit 10218a9 into rapidsai:branch-24.02 Nov 17, 2023
65 checks passed
@vuule vuule deleted the bug-write_json-default-stream-use branch November 17, 2023 22:15
@vuule vuule mentioned this pull request Nov 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@shrshi shrshi shrshi approved these changes

Assignees

@vuule vuule

Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @shrshi @ttnghia