REF: Remove **kwargs from to_pandas, raise if nullable is not implemented #14438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
wence-
reviewed
Nov 17, 2023
python/cudf/cudf/core/_base_index.py
Outdated
| @@ -850,7 +850,7 @@ def notna(self): | |||
| """ | |||
| raise NotImplementedError | |||
|
|
|||
| def to_pandas(self, nullable=False): | |||
| def to_pandas(self, nullable: bool = False): | |||
There was a problem hiding this comment.
suggestion: I think we should make all of these arguments keyword-only
def to_pandas(self, *, nullable: bool = False):
...
Rationale: API safety in the case when one can pass more than just nullable as an argument. WDYT?
There was a problem hiding this comment.
Agreed. Does that mean I should label this PR as breaking?
There was a problem hiding this comment.
This is probably an API break, yes.
wence-
added
breaking
wence-
reviewed
Nov 21, 2023
Comment on lines
+238
to
+245
| if isinstance(cudf_val, cudf.DataFrame): | ||
| pd_data = { | ||
| col: maybe_return_nullable_pd_obj(series) | ||
| for col, series in cudf_val.items() | ||
| } | ||
| pd_value = pd.DataFrame(pd_data) | ||
| else: | ||
| pd_value = maybe_return_nullable_pd_obj(cudf_val) |
There was a problem hiding this comment.
This is just handling that nullable=True was previously silently ignored for to_pandas calls that didn't support it, and now it is loud?
wence-
approved these changes
Nov 21, 2023
|
One test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist