Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error in reindex when index is not unique #14429

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Raise error in reindex when index is not unique #14429

merged 1 commit into from
Nov 16, 2023

Conversation

galipremsagar
Copy link
Contributor

Bacport of #14400
Fixes: #14398
This PR raises an error in reindex API when reindexing is performed on a non-unique index column.

Authors:

Approvers:

URL: #14400

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar
Raise error in reindex when index is not unique (rapidsai#14400)
314ac0e 
Fixes: rapidsai#14398 
This PR raises an error in `reindex` API when reindexing is performed on a non-unique index column.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Lawrence Mitchell (https://github.com/wence-)

URL: rapidsai#14400
@galipremsagar galipremsagar requested review from a team as code owners November 16, 2023 18:03
@galipremsagar galipremsagar requested review from wence- and mroeschke and removed request for a team November 16, 2023 18:03
@galipremsagar galipremsagar self-assigned this Nov 16, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 16, 2023
@galipremsagar galipremsagar added bug Something isn't working breaking Breaking change and removed Python Affects Python cuDF API. labels Nov 16, 2023
@galipremsagar galipremsagar changed the title Raise error in reindex when index is not unique (#14400) Raise error in reindex when index is not unique Nov 16, 2023
@galipremsagar galipremsagar added the ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround label Nov 16, 2023
rjzamora
rjzamora approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dask-cudf changes LGTM.

@raydouglass raydouglass merged commit 4dc8300 into rapidsai:branch-23.10 Nov 16, 2023
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzamora rjzamora rjzamora approved these changes

@shwina shwina shwina approved these changes

@raydouglass raydouglass raydouglass approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround breaking Breaking change bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @raydouglass @shwina @rjzamora