Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add Series level cumulative ops (sum, min, max, prod) in python layer #1441

Merged
merged 15 commits into from
Apr 17, 2019
Merged

[REVIEW] Add Series level cumulative ops (sum, min, max, prod) in python layer #1441

merged 15 commits into from
Apr 17, 2019

Conversation

beckernick
Copy link
Member

@beckernick beckernick commented Apr 17, 2019 •
edited
Loading

Summary of Changes

  • This PR adds the following cumulative operations methods to Series objects (analogous to pandas):
    • cummin
    • cummax
    • cumsum
    • cumprod
  • Adds a generic _apply_scan_op method to Numerical columns for applying a scan operation to a column
  • Renames test_prefixsum.py to test_scan.py to reflect an updated suite of tests for scans:
    • cummin
    • cummax
    • cumsum
    • cumprod

As a note, pandas casts all integer dtype columns to np.int64 for the cumsum and cumprod operations.

This PR closes #1269 , #1273 , #1274 using the libcudf scan functionality from #1005.

@kkraus14 kkraus14 added 2 - In Progress Currently a work in progress Python Affects Python cuDF API. labels Apr 17, 2019
@beckernick beckernick changed the title [WIP] Add Series level cumulative ops (sum, min, max, prod) in python layer [REVIEW] Add Series level cumulative ops (sum, min, max, prod) in python layer Apr 17, 2019
@beckernick beckernick self-assigned this Apr 17, 2019
@beckernick
Copy link
Member Author

rerun tests

@kkraus14 kkraus14 added 3 - Ready for Review Ready for review by team 4 - Needs cuDF Reviewer and removed 2 - In Progress Currently a work in progress labels Apr 17, 2019
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF Reviewer labels Apr 17, 2019
@kkraus14 kkraus14 merged commit d2362a9 into rapidsai:branch-0.7 Apr 17, 2019
This was referenced Apr 17, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randerzander randerzander randerzander left review comments

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

@beckernick beckernick

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Series level cumulative sum
3 participants
@beckernick @randerzander @kkraus14