Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup remaining usages of dask dependencies #14407

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR switches remaining usages of dask dependencies to use rapids-dask-dependency

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 14, 2023
@galipremsagar galipremsagar self-assigned this Nov 14, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner November 14, 2023 17:50
@github-actions github-actions bot added the conda label Nov 14, 2023
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Nov 14, 2023
@galipremsagar galipremsagar added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 5 - Ready to Merge Testing and reviews complete, ready to merge labels Nov 14, 2023
@galipremsagar
Copy link
Contributor Author

Holding off merging of this PR until new images are published.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Nov 14, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8106a0c into rapidsai:branch-23.12 Nov 14, 2023
72 of 88 checks passed
@vyasr vyasr mentioned this pull request Nov 15, 2023
3 tasks
raydouglass pushed a commit that referenced this pull request Nov 15, 2023
#14407 added a dask dependency to custreamz, but it added too tight of a pinning by requiring the exact same version. This is not valid because rapids-dask-dependency won't release a new version corresponding to each new cudf release, so pinning to the exact same version up to the alpha creates an unsatisfiable constraint.

Authors:
   - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
   - Ray Douglass (https://github.com/raydouglass)
   - Bradley Dice (https://github.com/bdice)
   - GALI PREM SAGAR (https://github.com/galipremsagar)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants