-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup remaining usages of dask dependencies #14407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Nov 14, 2023
bdice
approved these changes
Nov 14, 2023
AyodeAwe
approved these changes
Nov 14, 2023
galipremsagar
added
the
5 - Ready to Merge
Testing and reviews complete, ready to merge
label
Nov 14, 2023
vyasr
approved these changes
Nov 14, 2023
galipremsagar
added
5 - DO NOT MERGE
Hold off on merging; see PR for details
and removed
5 - Ready to Merge
Testing and reviews complete, ready to merge
labels
Nov 14, 2023
Holding off merging of this PR until new images are published. |
galipremsagar
force-pushed
the
cleanup
branch
from
November 14, 2023 18:58
227d7cb
to
bf7a199
Compare
galipremsagar
added
5 - Ready to Merge
Testing and reviews complete, ready to merge
and removed
5 - DO NOT MERGE
Hold off on merging; see PR for details
labels
Nov 14, 2023
/merge |
3 tasks
raydouglass
pushed a commit
that referenced
this pull request
Nov 15, 2023
#14407 added a dask dependency to custreamz, but it added too tight of a pinning by requiring the exact same version. This is not valid because rapids-dask-dependency won't release a new version corresponding to each new cudf release, so pinning to the exact same version up to the alpha creates an unsatisfiable constraint. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Ray Douglass (https://github.com/raydouglass) - Bradley Dice (https://github.com/bdice) - GALI PREM SAGAR (https://github.com/galipremsagar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches remaining usages of
dask
dependencies to userapids-dask-dependency
Checklist