Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always build nvbench statically so we don't need to package it #14399

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Always build nvbench statically so we don't need to package it #14399

merged 2 commits into from
Nov 14, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Corrects failures seen in C++ CI where libnvbench.so can't be found

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Nov 13, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner November 13, 2023 20:31
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 13, 2023
@vyasr vyasr mentioned this pull request Nov 14, 2023
Merged
@bdice
Copy link
Contributor

bdice commented Nov 14, 2023

/merge

@bdice
Copy link
Contributor

bdice commented Nov 14, 2023

This looks fine. Merging now to unblock CI for #14292 and other PRs.

@rapids-bot rapids-bot bot merged commit 5d09d38 into rapidsai:branch-23.12 Nov 14, 2023
62 checks passed
@robertmaynard robertmaynard deleted the bug/ensure_nvbench_is_built_statically branch November 14, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @bdice @vyasr