Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure slow private attrs are maybe proxies #14380

Merged
merged 10 commits into from
Feb 22, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Expected pandas test failures:

tests/indexing/test_indexing.py

Due to this PR, it appears an assert something._values is something_else fails more after this PR since ._values wraps objects in an proxy object now (a known failure mode)

tests/series/indexing/test_setitem.py

Runs into the issue where a test set up calls proxy._values[key] = something using a pandas helper function that isn't proxying correctly

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Nov 9, 2023
@mroeschke mroeschke requested a review from a team as a code owner November 9, 2023 00:43
@mroeschke mroeschke requested review from a team as code owners November 16, 2023 22:23
@mroeschke mroeschke changed the base branch from branch-23.12 to branch-24.02 November 16, 2023 22:23
@wence- wence- removed request for a team, mythrocks and PointKernel November 22, 2023 11:10
@mroeschke mroeschke changed the base branch from branch-24.02 to branch-24.04 January 31, 2024 21:37
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM.

python/cudf/cudf_pandas_tests/test_cudf_pandas.py Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Feb 21, 2024

@mroeschke Can you comment on the change in pandas test coverage / pass rate or any metrics like performance of particular code paths that change as a result of this PR?

@mroeschke
Copy link
Contributor Author

@mroeschke Can you comment on the change in pandas test coverage / pass rate or any metrics like performance of particular code paths that change as a result of this PR?

IIRC the net pandas test pass rate will decrease with this PR (down 1-2%), primarily due to the reasons in #14380 (comment)

However, this PR will help proxy the result of SlowObject._private_method_or_attribute which before would always be a pandas object and not a proxy object.

@bdice
Copy link
Contributor

bdice commented Feb 22, 2024

IIRC the net pandas test pass rate will decrease with this PR (down 1-2%), primarily due to the reasons in #14380 (comment)

Aha! I did not understand that comment until now. Thank you for clarifying what that meant.

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 2b57c61 into rapidsai:branch-24.04 Feb 22, 2024
69 checks passed
@mroeschke mroeschke deleted the bug/slow_attr_proxy branch February 22, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants