-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure slow private attrs are maybe proxies #14380
Ensure slow private attrs are maybe proxies #14380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise LGTM.
@mroeschke Can you comment on the change in pandas test coverage / pass rate or any metrics like performance of particular code paths that change as a result of this PR? |
Co-authored-by: Bradley Dice <[email protected]>
IIRC the net pandas test pass rate will decrease with this PR (down 1-2%), primarily due to the reasons in #14380 (comment) However, this PR will help proxy the result of |
Aha! I did not understand that comment until now. Thank you for clarifying what that meant. |
/merge |
Description
Expected pandas test failures:
Due to this PR, it appears an
assert something._values is something_else
fails more after this PR since._values
wraps objects in an proxy object now (a known failure mode)Runs into the issue where a test set up calls
proxy._values[key] = something
using a pandas helper function that isn't proxying correctlyChecklist