Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #14374

Merged
merged 12 commits into from
Nov 8, 2023
Merged

Update README #14374

merged 12 commits into from
Nov 8, 2023

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Nov 8, 2023

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

beckernick
beckernick previously requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@beckernick beckernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

  • Would consider adding automatic CPU fallback to the one sentence description of cudf.pandas
  • The cudf.pandas code snippet not included in the diff should use pd not cudf

README.md Outdated

## Resources
You can use cuDF directly, or easily accelerate existing pandas
code with `cudf.pandas`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
code with `cudf.pandas`:
code with `cudf.pandas`, with automatic CPU fallback if needed:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved things around a bit to include this.

jarmak-nv
jarmak-nv reviewed Nov 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
bdice
bdice reviewed Nov 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@shwina shwina added doc Documentation non-breaking Non-breaking change labels Nov 8, 2023
bdice
bdice approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. I think this is awesome! A few suggestions, and approving.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
shwina and others added 3 commits November 8, 2023 10:15
@shwina @bdice
Update README.md
7d6266b 
Co-authored-by: Bradley Dice <[email protected]>
@shwina @bdice
Update README.md
3f7868e 
Co-authored-by: Bradley Dice <[email protected]>
@shwina
rm output cell
7431d29
@shwina
Copy link
Contributor Author

shwina commented Nov 8, 2023

/merge

@shwina shwina requested a review from beckernick November 8, 2023 17:14
@rapids-bot rapids-bot bot merged commit d3dcc75 into rapidsai:branch-23.12 Nov 8, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarmak-nv jarmak-nv jarmak-nv left review comments

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@beckernick beckernick Awaiting requested review from beckernick

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shwina @bdice @beckernick @galipremsagar @jarmak-nv