Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose streams in Parquet reader and writer APIs #14359

Merged
merged 14 commits into from
Jan 11, 2024
Merged

Expose streams in Parquet reader and writer APIs #14359

merged 14 commits into from
Jan 11, 2024

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Nov 3, 2023 •
edited
Loading

Description

This PR contributes to #13744.
-Added stream parameters to public APIs

cudf::io::read_parquet
cudf::io::write_parquet
cudf::io::parquet_chunked_writer
cudf::io::chunked_parquet_reader

-Added stream gtests

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@shrshi shrshi added the improvement Improvement / enhancement to an existing function label Nov 3, 2023
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 3, 2023
@shrshi shrshi added CMake CMake build issue non-breaking Non-breaking change and removed CMake CMake build issue labels Nov 3, 2023
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 6, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shrshi
Copy link
Contributor Author

shrshi commented Nov 6, 2023

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Nov 6, 2023

/ok to test

@GregoryKimball GregoryKimball mentioned this pull request Nov 22, 2023
Open
@shrshi shrshi changed the base branch from branch-23.12 to branch-24.02 January 3, 2024 20:17
@shrshi
Copy link
Contributor Author

shrshi commented Jan 5, 2024

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Jan 5, 2024

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Jan 5, 2024

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Jan 5, 2024

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Jan 5, 2024

/ok to test

@shrshi shrshi marked this pull request as ready for review January 5, 2024 22:18
@shrshi shrshi requested a review from a team as a code owner January 5, 2024 22:18
@vuule vuule self-requested a review January 10, 2024 23:52
vuule
vuule approved these changes Jan 11, 2024
View reviewed changes
cpp/tests/streams/io/parquet_test.cpp
std::vector<std::unique_ptr<cudf::column>> make_uniqueptrs_vector(UniqPtrs&&... uniqptrs)
{
std::vector<std::unique_ptr<cudf::column>> ptrsvec;
(ptrsvec.push_back(std::forward<UniqPtrs>(uniqptrs)), ...);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg, a fold expression
very cool

cpp/tests/streams/io/parquet_test.cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PQ reader launches a separate kernel for many different encoding types; in theory we need to cover all those kernels. But, I think we can ignore this for now, since it requires carefully crafting tests that lead to specific encodings.
CC @nvdbaranec @etseidl for viz (short for wizardry)

@shrshi
Copy link
Contributor Author

shrshi commented Jan 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit e50fa00 into rapidsai:branch-24.02 Jan 11, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@harrism harrism harrism approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@shrshi shrshi

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrshi @harrism @vuule