Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fmt 10.1.1 and spdlog 1.12.0. #14355

Merged
merged 13 commits into from
Nov 30, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 3, 2023

This PR updates to fmt 10.1.1 and spdlog 1.12.

Depends on rapidsai/rmm#1374.

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 3, 2023
@github-actions github-actions bot added the conda label Nov 3, 2023
@bdice
Copy link
Contributor Author

bdice commented Nov 13, 2023

I'll test rapidsai/gha-tools#85 in this PR once it's available.

@bdice bdice changed the base branch from branch-23.12 to branch-24.02 November 16, 2023 05:26
@github-actions github-actions bot added the ci label Nov 20, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 22, 2023
@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 30, 2023
@bdice bdice changed the title Build with fmt 10.1.1 and spdlog 1.12.0. Update to fmt 10.1.1 and spdlog 1.12.0. Nov 30, 2023
@bdice
Copy link
Contributor Author

bdice commented Nov 30, 2023

Revert changes that use CI artifacts and the upstream rapids-cmake branch before merging.

@bdice bdice self-assigned this Nov 30, 2023
@bdice bdice marked this pull request as ready for review November 30, 2023 16:14
@bdice bdice requested review from a team as code owners November 30, 2023 16:14
@bdice bdice requested review from vyasr and karthikeyann November 30, 2023 16:14
@github-actions github-actions bot removed the ci label Nov 30, 2023
@bdice bdice removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 30, 2023
@bdice
Copy link
Contributor Author

bdice commented Nov 30, 2023

/merge

@raydouglass raydouglass merged commit c8074b5 into rapidsai:branch-24.02 Nov 30, 2023
66 checks passed
raydouglass pushed a commit to rapidsai/ucxx that referenced this pull request Nov 30, 2023
This PR updates to fmt 10.1.1 and spdlog 1.12.

Depends on rapidsai/cudf#14355.

Authors:
   - Bradley Dice (https://github.com/bdice)

Approvers:
   - Vyas Ramasubramani (https://github.com/vyasr)
   - Jake Awe (https://github.com/AyodeAwe)
   - Lawrence Mitchell (https://github.com/wence-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants