Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow check in cudf::merge #14345

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

divyegala
Copy link
Member

Description

#14250 added a check to ensure cudf::merge throws when the total number of merged rows exceed cudf::size_type limit, however @bdice pointed out that the check was not correct because the accumulation was still occurring in cudf::size_type. This PR computes the accumulation in std::size_t.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@divyegala divyegala added bug Something isn't working non-breaking Non-breaking change labels Oct 30, 2023
@divyegala divyegala self-assigned this Oct 30, 2023
@divyegala divyegala requested a review from a team as a code owner October 30, 2023 15:44
@divyegala divyegala requested review from vyasr and ttnghia October 30, 2023 15:44
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 30, 2023
@divyegala
Copy link
Member Author

/merge

Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue keeps showing up many times and this is just fixing the leaf, not the root of the problem. Probably we should consider a better approach: changing column(_view)::size() to return int64_t instead.

@rapids-bot rapids-bot bot merged commit ec080eb into rapidsai:branch-23.12 Oct 31, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants