Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cramjam #14344

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add cramjam #14344

merged 1 commit into from
Oct 30, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 29, 2023 •
edited
Loading

Description

As of fastavro 1.9.0 (released on October 27) the recommend method for snappy decompression is via the cramjam package. We need to install it to avoid getting deprecation warnings involving python-snappy usage.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Oct 29, 2023
@vyasr vyasr self-assigned this Oct 29, 2023
@vyasr vyasr requested review from a team as code owners October 29, 2023 23:20
@vyasr vyasr requested review from wence- and charlesbluca October 29, 2023 23:20
@github-actions github-actions bot added the conda label Oct 29, 2023
@vyasr vyasr mentioned this pull request Oct 29, 2023
Merged
3 tasks
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 2548509 into rapidsai:branch-23.12 Oct 30, 2023
54 checks passed
@vyasr vyasr deleted the fix/add_cramjam_dep branch October 30, 2023 16:18
@vyasr vyasr mentioned this pull request Feb 27, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@wence- wence- wence- approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @galipremsagar @wence- @raydouglass