Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily avoid the current build of pydata-sphinx-theme #14332

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 25, 2023

Description

There appears to be a bug in the latest release of pydata-sphinx theme where a warning that was intended to be thrown conditionally is appearing unconditionally in our builds, triggering a doc build failure because we build with -W. See pydata/pydata-sphinx-theme#1539 for more information. We should be OK to simply avoid the current version for now. If the next release is a minor release then the warning will be removed and we can automatically upgrade. If they have another patch release then we can reevaluate the pinning, but the current pinning seems like the most likely to require no additional work going forward.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Oct 25, 2023
@vyasr vyasr self-assigned this Oct 25, 2023
@vyasr vyasr requested a review from a team as a code owner October 25, 2023 23:16
@github-actions github-actions bot added the conda label Oct 25, 2023
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is a good time to point out the new RAPIDS sphinx theme below that we're currently working on. In the future, that theme will handle the PyData theme pin for all of RAPIDS. Allan and I are working on that as time permits.

@davidwendt
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 203f1df into rapidsai:branch-23.12 Oct 26, 2023
57 checks passed
@vyasr vyasr deleted the fix/pydata_sphinx_theme_warning branch October 26, 2023 15:35
@vyasr vyasr mentioned this pull request Oct 26, 2023
3 tasks
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Oct 26, 2023
See pydata/pydata-sphinx-theme#1539 and rapidsai/cudf#14332 for additional context.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants