Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade arrow to 13 #14330

Merged
merged 27 commits into from
Oct 27, 2023
Merged

Upgrade arrow to 13 #14330

merged 27 commits into from
Oct 27, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR upgrades arrow to 13.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 25, 2023
@galipremsagar galipremsagar self-assigned this Oct 25, 2023
@galipremsagar galipremsagar requested review from a team as code owners October 25, 2023 20:44
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue conda labels Oct 25, 2023
@galipremsagar galipremsagar mentioned this pull request Oct 25, 2023
Closed
3 tasks
bdice
bdice approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @galipremsagar!

@github-actions github-actions bot added the ci label Oct 26, 2023
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 26, 2023
@pentschev pentschev mentioned this pull request Oct 26, 2023
Merged
@github-actions github-actions bot removed the ci label Oct 26, 2023
@bdice
Copy link
Contributor

bdice commented Oct 27, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7d6c377 into rapidsai:branch-23.12 Oct 27, 2023
55 checks passed
@csadorf csadorf mentioned this pull request Oct 27, 2023
Merged
@vyasr vyasr mentioned this pull request Oct 27, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Oct 31, 2023
@vyasr
Upgrade wheels to use arrow 13 (#14339)
b4746d8 
In #14330 we upgraded to Arrow 13. However, we only did so for conda packages. For wheels, we couldn't do the same because pyarrow 13 started supporting two manylinux versions, both 2.17 and 2.28. This results in ABI compatibility issues because cudf wheels bundle an identical libarrow and was previously configured to compile with the CXX11 ABI turned off for compatibility with the  libarrow in the 2.17 wheels. To address this, this PR modifies the CMake logic to only set that flag conditionally based on the glibc version on the host system.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Robert Maynard (https://github.com/robertmaynard)
  - Ray Douglass (https://github.com/raydouglass)
  - Bradley Dice (https://github.com/bdice)

URL: #14339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

@vyasr vyasr vyasr approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @bdice @vyasr @jakirkham @raydouglass