Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stream parameter in public nvtext replace APIs #14329

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Expose stream parameter in public nvtext replace APIs #14329

merged 6 commits into from
Nov 7, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Add stream parameter to public APIs:

  • nvtext::replace_tokens()
  • nvtext::filter_tokens
  • nvtext::normalize_spaces()
  • nvtext::normalize_characters()

Also cleaned up some of the doxygen comments and added stream gtests.

Reference #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 25, 2023
@davidwendt davidwendt self-assigned this Oct 25, 2023
@github-actions github-actions bot added the CMake CMake build issue label Oct 25, 2023
@vyasr vyasr mentioned this pull request Oct 25, 2023
Closed
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 27, 2023
@davidwendt davidwendt marked this pull request as ready for review October 27, 2023 13:24
@davidwendt davidwendt requested a review from a team as a code owner October 27, 2023 13:24
@davidwendt davidwendt requested review from mythrocks and vuule October 27, 2023 13:24
mythrocks
mythrocks approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. LGTM!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 16051a7 into rapidsai:branch-23.12 Nov 7, 2023
54 checks passed
@davidwendt davidwendt deleted the stream-nvtext-replace branch November 7, 2023 16:15
@davidwendt davidwendt mentioned this pull request Nov 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@mythrocks mythrocks mythrocks approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @mythrocks @vuule